search

space-ros / simulation

Simulation assets of space-ros demos
9 stars 19 forks source link

Fix loading of `RobotModel` in Rviz #15

Closed ibrahiminfinite closed 6 months ago

ibrahiminfinite commented 8 months ago

Fixes: https://github.com/space-ros/demos/issues/25

This PR adds the missing file:/// keyword to the <mesh> tags enabling Rviz to properly load the files.

mkhansenbot commented 8 months ago

Can you provide a quick list of instructions how you tested this? I'm running it and don't see a difference, the Robot Model isn't appearing in Rviz. I'm probably missing something in the setup.

ibrahiminfinite commented 8 months ago

The only change required is to repalce the simulation repo in this file to the PR branch

  simulation:
    type: git
    url: https://github.com/ibrahiminfinite/simulation.git
    version: rviz_robot_model

After that is done, you can follow the original guide here to buld the image and run the simulation.

Now if you open rviz and add the robot model, it should be visible.

Adding a video for reference

robot_model_rviz_load.webm

mkhansenbot commented 7 months ago

What launch commands are you running?

ibrahiminfinite commented 7 months ago

What launch commands are you running?

ros2 launch mars_rover mars_rover.launch for the simulation

Also in another sourced terminal of the same docker container

ros2 run rviz2 rviz2 for launching rviz

quarkytale commented 7 months ago

Would need to make sure this change is compatible with Gazebo as well.

EzraBrooks commented 6 months ago

Fixed in #17