search

space-ros / spaceros.org

The Space ROS website.
9 stars 0 forks source link

Deploy to Github Pages automatically + HTTPS fixes #12

Closed german-e-mas closed 1 year ago

german-e-mas commented 1 year ago

This PR allows us to automatically build and deploy the site to gh-pages whenever we push changes into master.

Attempts to fix:

Workflow

The included workflow is in charge of:

Note: We need to set the repository's pages to serve the root folder of gh-pages this way. I believe it's more straightforward this way, and we don't depend on a /docs folder, for example.

Regarding HTTPS

Currently, the site is served without enforcing HTTPS (http://space.ros.org/). When we visit it's HTTPS counterpart, things break (https://space.ros.org/).

To fix this, I believe we need to attack this problem on two fronts:

1) Change the SITEURL to be space.ros.org instead of the Github assigned URL. Otherwise we get mixed content and some redirects internal to the blog are not aware of the proper URL.

1) In order to enforce HTTPS, we need to have space.ros.org as a Verified Domain inside Github, and make sure the DNS records are correct. EDIT: We do not need a Verified Domain.

About the Domain Verification

The owner of @space-ros organization can do that. See Verifying your custom domain for GitHub Pages. To verify the domain, we need a TXT record to be set at the DNS level. Maybe @nuclearsandwich can gives us a hand on that part.

EDIT: We do not need a Verified Domain.

Can you ptal @mjeronimo ? If you can give me access to this repository's settings regarding pages, I can double check that the custom domain and pages are working as intended.

german-e-mas commented 1 year ago

@mjeronimo , can you give me permissions over this repository's page settings? So I can apply the changes required before merging.

Also, merging is blocked because my commits weren't sign. How can I fix this?