search

space-voyager-21 / space-voyager

Interactive Space App . Attention Contributers! join discord server for discussion of Issues, Pull requests https://discord.gg/FpEK9AqbCf
https://space-voyager.netlify.app/
MIT License
19 stars 23 forks source link

Satellite page styling issues in smaller size device #44

Closed minhhang107 closed 3 years ago

minhhang107 commented 3 years ago

Describe the bug Satellite page has some styling issues when viewed on phone/tablet screens:

  1. Satellite image is covering other components (covering Submit button on phone screen, covering Search bar on tablet screen) (see screenshot 1)
  2. When there's no result for search, error texts are not centered (see screenshot 2)
  3. When there's no result for search, error text shows "We don't know about the planet.." (see screenshot 2)

To Reproduce Steps to reproduce the behavior:

  1. Go to https://space-voyager.vercel.app/satellite on a mobile device
  2. Search for an invalid satellite (eg: abc)
  3. See error

Expected behavior

  1. Satellite image should not cover any other components
  2. When there's no result for search, error texts should be centered
  3. When there's no result for search, error text should show "We don't know about the satellite.."

Screenshots

voyager2

voyager1

minhhang107 commented 3 years ago

I would like to work on this issue. Can I be assigned?

mohittk commented 3 years ago

Describe the bug Satellite page has some styling issues when viewed on phone/tablet screens:

  1. Satellite image is covering other components (covering Submit button on phone screen, covering Search bar on tablet screen) (see screenshot 1)
  2. When there's no result for search, error texts are not centered (see screenshot 2)
  3. When there's no result for search, error text shows "We don't know about the planet.." (see screenshot 2)

To Reproduce Steps to reproduce the behavior:

  1. Go to space-voyager.vercel.app/satellite on a mobile device
  2. Search for an invalid satellite (eg: abc)
  3. See error

Expected behavior

  1. Satellite image should not cover any other components
  2. When there's no result for search, error texts should be centered
  3. When there's no result for search, error text should show "We don't know about the satellite.."

Screenshots

voyager2

voyager1

Ohh Yea! I observed the issues very well. Glad that you saw that so closely. Can you fix them? @minhhang107

mohittk commented 3 years ago

I would like to work on this issue. Can I be assigned?

Yea! sure. All the best.