Added in-built media player to play video without navigating to another window

[ramdevcm]

[vercel[bot]]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mohit-space/space-voyager/99RAHSovfJwTe57MdujrARW1QW9K
✅ Preview: https://space-voyager-git-fork-ramdevcm-master-mohit-space.vercel.app

[mohittk]

@ramdevcm I don't quite get it what you are willing to add? Before making any off-topic pull request. Please do create issue.

[ramdevcm]

can I know why this is labelled as invalid?

[mohittk]

can I know why this is labelled as invalid?

Deployment got failed. and in addition to it, you did'nt created any issue for this.

[umgbhalla]

can I know why this is labelled as invalid?

because it fails ci deployment on vercel

[ramdevcm]

This was the issue

[ramdevcm]

image/video not played/displayed

[ramdevcm]

should I need to create an issue?

[mohittk]

should I need to create an issue?

Yes! you should. It will be better, and check what error you got while deploying

[umgbhalla]

@mohittk copy paste deployment logs here , its setup on your account hence only you have access

[mohittk]

@ramdevcm checkout logs right here. 13:51:13.738 Cloning github.com/space-voyager-21/space-voyager (Branch: master, Commit: 7915063) 13:51:14.576 Cloning completed: 837.411ms 13:51:14.601 Analyzing source code... 13:51:15.908 Installing build runtime... 13:51:18.322 Build runtime installed: 2.414s 13:51:20.823 Looking up build cache... 13:51:23.356 Build cache downloaded [32.94 MB]: 2312.579ms 13:51:24.625 Detected package.json 13:51:24.625 Installing dependencies... 13:51:24.936 yarn install v1.22.11 13:51:25.038 [1/4] Resolving packages... 13:51:25.819 success Already up-to-date. 13:51:25.826 Done in 0.90s. 13:51:26.363 > space-app@0.1.0 build /vercel/path0 13:51:26.363 > react-scripts build 13:51:27.977 Creating an optimized production build... 13:51:30.782 Failed to compile. 13:51:30.783 ./src/components/apod/Apod.js 13:51:30.783 Cannot find module: 'react-player/lazy'. Make sure this package is installed. 13:51:30.784 You can install this package by running: yarn add react-player/lazy. 13:51:30.799 npm ERR! code ELIFECYCLE 13:51:30.799 npm ERR! errno 1 13:51:30.802 npm ERR! space-app@0.1.0 build: react-scripts build 13:51:30.803 npm ERR! Exit status 1 13:51:30.803 npm ERR! 13:51:30.803 npm ERR! Failed at the space-app@0.1.0 build script. 13:51:30.803 npm ERR! This is probably not a problem with npm. There is likely additional logging output above. 13:51:30.816 npm ERR! A complete log of this run can be found in: 13:51:30.816 npm ERR! /vercel/.npm/_logs/2021-10-10T08_21_30_803Z-debug.log 13:51:30.831 Error: Command "CI=false npm run build" exited with 1

[umgbhalla]

ig he didnt push package.json

[mohittk]

ig he didnt push package.json

Are you sure? you mean any problem in dependencies?

[umgbhalla]

ig he didnt push package.json

Are you sure? you mean any problem in dependencies?

13:51:30.783 Cannot find module: 'react-player/lazy'. Make sure this package is installed. 13:51:30.784 You can install this package by running: yarn add react-player/lazy.

😑

[ramdevcm]

yes added a new package

[mohittk]

ig he didnt push package.json

Are you sure? you mean any problem in dependencies?

13:51:30.783 Cannot find module: 'react-player/lazy'. Make sure this package is installed. 13:51:30.784 You can install this package by running: yarn add react-player/lazy.

😑

Ohh yea! here it is.

[umgbhalla]

yes added a new package

then commit and push package.json without closing this pull request

[ramdevcm]

can you add it?? or should I PR again?

[ramdevcm]

OK @umgbhalla

[umgbhalla]

u dont need to close this pr , just commit and push @ramdevcm

[ramdevcm]

Code Pushed

[umgbhalla]

@mohittk you can merge now

[mohittk]

@ramdevcm You did it finally!

[ramdevcm]

Hehee... Thank you, Guys