search

space-voyager-21 / space-voyager

Interactive Space App . Attention Contributers! join discord server for discussion of Issues, Pull requests https://discord.gg/FpEK9AqbCf
https://space-voyager.netlify.app/
MIT License
19 stars 23 forks source link

Add hover effect to those 9 planets. #57

Closed omkar342 closed 3 years ago

omkar342 commented 3 years ago

Hey @mohittk, I think we should add a hover effect to all the images of those 9 planets on the planets page. As it's looking very plane on hovering on it right now. Where we can increase or decrease the scale of that images. Let me know your thoughts on this.

mohittk commented 3 years ago

Hey @mohittk, I think we should add a hover effect to all the images of those 9 planets on the planets page. As it's looking very plane on hovering on it right now. Where we can increase or decrease the scale of that images. Let me know your thoughts on this.

You can do it, but it is very small change, so think of any other change too, so that I can accept the PR.

omkar342 commented 3 years ago

Yes, I will think of some ideas while working on it.

omkar342 commented 3 years ago

Hey @mohittk, do you know how we can add both animation and hover effect to any element? Because I am not able to do that. As either animation of rotation is working or the hover effect is working on the image. I am not able to do both. Do you have any suggestions?

mohittk commented 3 years ago

Hey @mohittk, do you know how we can add both animation and hover effect to any element? Because I am not able to do that. As either animation of rotation is working or the hover effect is working on the image. I am not able to do both. Do you have any suggestions?

I don't have any idea regarding that one. Research for it on google.

tyler-morales commented 3 years ago

I can help with this! Let me know if you want to assign it to me :)

mohittk commented 3 years ago

I can help with this! Let me know if you want to assign it to me :)

Elaborate, what changes you gonna make to make the user-interface better? Particularly in this one.

tyler-morales commented 3 years ago

@mohittk Currently, I don't see any focus, hover, or selected styles on any of the planets.

  1. I'd like to add hover and focus style to increase the scale of the planet
  2. Add a selected style: a ring around each planet when it is selected
mohittk commented 3 years ago

@mohittk Currently, I don't see any focus, hover, or selected styles on any of the planets.

  1. I'd like to add hover and focus style to increase the scale of the planet
  2. Add a selected style: a ring around each planet when it is selected

umm.. okay! Go for it. add something new design or feature in addition to hover effects.

mohittk commented 3 years ago

Solved in #66 !