search

space-wizards / RobustToolbox

Robust multiplayer game engine, used by Space Station 14
https://spacestation14.io
Other
497 stars 376 forks source link

MIDI sequencer sends events to the synth directly. #1768

Closed Zumorica closed 2 years ago

Zumorica commented 3 years ago

It should go through the renderer's SendMidiEvent() instead, using a callback.

Zumorica commented 2 years ago

This is painful to fix because we need a way to cast SequencerEvent to our own MidiEvent type. And there's also no way to handle sequencer events of the Note type (which means to hold a note for X time)

Zumorica commented 2 years ago

Fixed by #2666