space-wizards / RobustToolbox

Robust multiplayer game engine, used by Space Station 14
https://spacestation14.io
Other
504 stars 380 forks source link

Slider Event Flood Issue #2411

Open wrexbe opened 2 years ago

wrexbe commented 2 years ago

Sliders create a ton of events when you are dragging them, consider changing it to only send an event when you release the slider, or rate limiting it.

One place where this backfires is here space-station-14\Content.Server\Atmos\Piping\Unary\EntitySystems\GasCanisterSystem.cs OnCanisterChangeReleasePressure

It creates a lot of logs, but even without that, it would probably be slow.

PaulRitter commented 2 years ago

prob needs a toggle between both & some threshold on which change it will raise a new event while the slider is being dragged

metalgearsloth commented 2 years ago

I think only doing it on release is better and more consistent which is when the input should happen IMO.