search

space-wizards / RobustToolbox

Robust multiplayer game engine, used by Space Station 14
https://spacestation14.io
Other
496 stars 375 forks source link

UIController subscription's don't work #5239

Open metalgearsloth opened 3 weeks ago

metalgearsloth commented 3 weeks ago

This is the actual cause of https://github.com/space-wizards/space-station-14/issues/28559

The problem is eventsubs get cleared on entitymanager shutdown (AKA when the sim shuts down). UIController lifetimes do not match EntityManager and they do not handle this so all of their subscriptions get removed.

deltanedas commented 3 weeks ago

shouldnt ui controllers not be subscribing to events??

metalgearsloth commented 3 weeks ago

shouldnt ui controllers not be subscribing to events??

Realistically they should have all eventsub functionality removed yeah.

juliangiebel commented 3 weeks ago

Isn't that UI controllers whole spiel? Behaving like an entity system?