space-wizards / RobustToolbox

Robust multiplayer game engine, used by Space Station 14
https://spacestation14.io
Other
537 stars 395 forks source link

Remove incorrect NotNullIfNotNull attributes in SharedAudioSystem #5449

Closed ElectroJr closed 2 weeks ago

ElectroJr commented 2 weeks ago

Several of these methods can return null even if the given parameter is not null, leading to NREs. In particular, this can happen if the caller is trying to play sounds attached to a terminating or deleted entity.

Requires a content PR to fix null check errors: https://github.com/space-wizards/space-station-14/pull/32233