search

space-wizards / SS14.Launcher

Launcher for Space Station 14.
https://spacestation14.io
MIT License
34 stars 54 forks source link

update nix to 23.11 #118

Closed lizelive closed 7 months ago

PJB3005 commented 7 months ago

cc @Zumorica ?

lizelive commented 7 months ago

this goes with https://github.com/space-wizards/SS14.Launcher/pull/117 as well

Zumorica commented 7 months ago

Actually tested this now and it does in fact break it-- @lizelive Just pull the changes in #117 into this PR, no need to keep them separate.

lizelive commented 7 months ago

@Zumorica did requested changes but please note master is currently broken (fixed in #117 ) hence why i split into two prs

Zumorica commented 7 months ago

@lizelive master with the 23.05 input does work fine, SS14.Loader ends up in the right directory and using the changes in #117 without the 23.11 input update breaks it. Apparently, some change from 23.05 to 23.11 broke this, which is why if you override the input, the loader won't be loaded properly (see corresponding nixpkgs PR that fixed that originally https://github.com/NixOS/nixpkgs/pull/240410) But anyway, thanks for the PR! I'm happy to see some people are interested in the Nix support :relieved:

@PJB3005 Feel free to merge this whenever possible, thank you