search

space-wizards / SS14.Launcher

Launcher for Space Station 14.
https://spacestation14.io
MIT License
34 stars 54 forks source link

Remove dynamic PGO option and make it default #130

Closed VasilisThePikachu closed 6 months ago

VasilisThePikachu commented 6 months ago

As far as I know, no one has experienced an issue with it. May as well remove some clutter. And make sure its on by default

deathride58 commented 6 months ago

The setting is somewhat useful; dynamic PGO does add a bit of startup time to the client, due to how large the assembly is. Though making it default would probably be a good idea.

VasilisThePikachu commented 6 months ago

The setting is somewhat useful; dynamic PGO does add a bit of startup time to the client, due to how large the assembly is. Though making it default would probably be a good idea.

I would take client performance over a little bit extra startup time

deathride58 commented 6 months ago

The extra startup time is not insignificant on lower-end hardware

VasilisThePikachu commented 6 months ago

How much longer is it? And how low end are we talking?

PJB3005 commented 6 months ago

The extra startup time is not insignificant on lower-end hardware

Do you have numbers on this? And are these up-to-date with .NET 8? I know they've had tons of improvements with OSR and similar.

deathride58 commented 6 months ago

We do not, admittedly! Plus it's been quite a while since we last poked at it ourself (and coincidentally it's been quite a while since we had a computer where it actually mattered). It's something that should probably be benchmarked proper.

PJB3005 commented 6 months ago

We could turn the checkmark into something that disables Full PGO instead, and clearly mark it as such.

VasilisThePikachu commented 6 months ago

So this is on decently good hardware. But having the option turned on or off does not impact startup time at all.

About 9 second from launch to game

I sadly don't own any too old hardware

VasilisThePikachu commented 6 months ago

Some more findings:

MacBook air m1 (battery saving mode to give it a disadvantage)

With PGO enabled: 30 seconds to get from launcher to game With PGO off: 25 seconds

Windows laptop with an intel i5 5200u, 8gb ram PGO on: 35 seconds PGO off: 30 seconds

Seems all around on weak hardware it's about 5 more seconds for launch.