space-wizards / SS14.Launcher

Launcher for Space Station 14.
https://spacestation14.io
MIT License
34 stars 54 forks source link

Make logging default (and clear out launcher logs each day) #131

Open VasilisThePikachu opened 6 months ago

VasilisThePikachu commented 6 months ago

Since Serilog is weird it appends the date to the log file now. Idk why but its fine since its configured to delete logs older then a day

This PR does the following:

  1. Removing the launcher logging checkbox in settings.
  2. Replace the checkbox in the login to opening the logs folder.
  3. Make launcher logs always be written.
  4. (Side effect of serilog) apends dates to the log file (launcher-DDMMYYY.log)... I guess it can help with knowing when a bug seemed to pop up.
  5. Clear out the log file if it's a day old.

Recommended to also update the !logging command in this case potencially.

Also adds an open launcher logs button instead of a log launcher button on login

moonheart08 commented 2 months ago

Make it delete if it's two days old, keep the last 2d of logs. Otherwise there will be a rollover point where it eats the old logs even if they were important.

VasilisThePikachu commented 2 months ago

Make it delete if it's two days old, keep the last 2d of logs. Otherwise there will be a rollover point where it eats the old logs even if they were important.

Sadly it looks like I don't have that kind of power with serilogs rolling interval. Closest i got is week

moonheart08 commented 2 months ago

Make it delete if it's two days old, keep the last 2d of logs. Otherwise there will be a rollover point where it eats the old logs even if they were important.

Sadly it looks like I don't have that kind of power with serilogs rolling interval. Closest i got is week

Probably better to retain more logs than necessary than to miss necessary logs. @PJB3005's opinion is probably needed.

github-actions[bot] commented 1 month ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 1 month ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.