space-wizards / SS14.Launcher

Launcher for Space Station 14.
https://spacestation14.io
MIT License
34 stars 54 forks source link

Replays fail to load if they were made using a vulnerable robust version or were recorded on dotnet 7 #142

Closed VasilisThePikachu closed 4 months ago

VasilisThePikachu commented 4 months ago

Just noticed there is no issue for this so may as well

After https://github.com/space-wizards/SS14.Launcher/commit/8ef2bd25d316574b657f4814ea5d848509a21385 reports of these were starting to come back. Due to the engine version being redirected.

https://github.com/space-wizards/SS14.Launcher/commit/2dd097f78e13286b5ecb5adaf9b05db219434faf was the first time these reports were seen. That made all replays recorded before net 8 unwatchable

I'm unsure if you can do anything on the launcher about this. Feel free to move this to robust or content if its more appropriate

This may be an issue again when we go to dotnet 9 (when it releases) or if there is a need to backport bug fixes.