space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.53k stars 3.14k forks source link

Strong forces applied to mob or item may clip them through walls #10394

Open Myctai opened 2 years ago

Myctai commented 2 years ago

Description

Strong forces applied to mob or item may clip them through walls. No idea how difficult this one is to fix, but having high-velocity objects not phase through walls would be nice.

Reproduction

Screenshots Pictured: owner of pAI activated syndicate minibomb, dropped into crit, got gibbed by bomb and had their pAI launched into space with explosion: explosion_clipped_item_through_wall

Additional context Related: issues like #10362.

Myctai commented 2 years ago

Uh, also grids seem to experience this issue. I saw shuttles clip into station couple of times.

Elijahrane commented 2 years ago

Extremely common bug that I can confirm, we have to teleport people/objects out of walls constantly

metalgearsloth commented 1 year ago

Grids use a different data structure.

https://github.com/space-wizards/RobustToolbox/issues/3116

koteq commented 7 months ago

https://github.com/space-wizards/space-station-14/assets/1192090/2f1000e3-8278-4562-a1e9-e90c0bf784cc

The most common reproduction of the tunneling bug I see often is when someone slips through a table into a wall. The substepping (https://github.com/space-wizards/RobustToolbox/issues/3116) doesn't prevent the bug, perhaps it needs more steps. And since TOI (https://github.com/space-wizards/RobustToolbox/issues/1693) isn't happening, maybe there should be other prevention/mitigation mechanics in place, such as https://github.com/space-wizards/RobustToolbox/issues/1022 or https://github.com/space-wizards/space-station-14/issues/17253

UPD: Though I'm not sure if it's actually tunneling or not. Does the engine allow entering on top of a table if you have a high enough velocity?

UPD2: It isn't tunneling, it's a special case related to some collision groups being disabled on mobs in downed state, see https://github.com/space-wizards/space-station-14/pull/24122