space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.73k stars 3.47k forks source link

Blood puddles: misleading visuals and mopping messages #11830

Closed Willhelm53 closed 1 year ago

Willhelm53 commented 2 years ago

Description

Reproduction

Screenshots

https://user-images.githubusercontent.com/97707302/194965238-f9e8725d-0b8f-4189-b1fe-f8eadc6bd0df.mp4

https://user-images.githubusercontent.com/97707302/194965840-3034062f-5878-4c8a-be27-68f9a1cabc4d.mp4

Additional context

As I noted in #6848, MopLowerLimit needs to be moved from the AbsorbentComponent to the PuddleComponent (so that, for example, we could make blood fully mop-up-able, but water and other types of puddle would still leave the wet-floor-residue).

I still wanna refactor puddle visuals so the wet floor sparkles only appear when the following three conditions are met:

  1. The puddle is too small for the mop to pick it up (Janitor should move onto the next one)
  2. The puddle will evaporate on its own (Janitor doesn't need to worry about this one anymore, beyond maybe placing a wet floor sign)
  3. The puddle can still slip people (People should watch out for the sparkle effect. See also: wet floor sign)
Willhelm53 commented 2 years ago

Someone can assign me to this because I wanna tackle this in the short-to-medium term.

Willhelm53 commented 2 years ago

Still going to do this one, but waiting for #11941