search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.54k stars 3.15k forks source link

Admin Logs are plagued with dead/nonfunctional/incomplete type filters #11896

Open Streaky-Haddock opened 1 year ago

Streaky-Haddock commented 1 year ago

Admin Logs have a lot of type filters that don't do anything and either should, or need to be removed because they're obsolete.

• Dead Types

○ Anchor ○ AtmosFilterChanged ○ AttackArmedClick ○ AttackArmedWide ○ AttackUnarmedClick ○ AttackUnarmedWide ○ CanisterPurged ○ Construction ○ Drop ○ EventAnnounced ○ EventRan ○ EventStarted ○ EventStopped ○ Explosion ○ Hunger ○ Ingestion ○ Radiation ○ Respawn ○ ShuttleCalled - Categorised as Action (Extreme) instead ○ ShuttleRecalled - Shuttle Recalls are Extreme Actions ○ Thirst ○ Unanchor ○ Unknown - Though I think this is meant to be empty if things are going well.

• Filters missing info but otherwise functional (These may be working as intended but honestly they seem extremely vacant but not totally)

○ CableCut - Sometimes fails to log cables being cut. Cables being mended show up as a generic interaction, which does not stand out. ○ Chemical Reaction - Only shows dispensing, and never the resultant chemical. If I don't know romerol from lexorin, I don't know what i'm looking at. Everything in this category is also considered 'medium' priority. Ideally dispensing would be low priority and resulting reactions should be medium. ○ Gib - Only shows Monkey Spiking. Not Reclaimer or Beating into pieces. Reclaimer shows up under Extreme Actions ○ RCD - Doesn't track mode swapping ○ ReagentEffect - Only Tracks Flammable Reactions. I suspect low activity, but I also doubt this has been kept up to date either. It sure doesn't track beaker bombs. ○ StorePurchase - Lots of blank entries. i.e 'purchased listing of "" from syndicate uplink' ○ Trigger - Mines don't show up when triggered

TBH admin logs are in serious need of a redesign imo but this issue limits itself to identifying things that don't work as intended. Most of these are things that are no longer necessary anymore (like hunger/thirst/explosive decompression) and should be removed, but other things need looking at.

I have a side-complaint about everything being genericised, but that falls out of the scope of this issue.

Mirino97 commented 1 year ago

While I currently do not possess the knowledge to fully rewrite the Log system/UI, what I CAN do is revive most of these filters, guaranteeing that the information they're supposed to filter shows up correctly, which I'll be doing tomorrow.

Geekyhobo commented 8 months ago

While I currently do not possess the knowledge to fully rewrite the Log system/UI, what I CAN do is revive most of these filters, guaranteeing that the information they're supposed to filter shows up correctly, which I'll be doing tomorrow.

Did you every get around to verifying these?