space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.61k stars 3.26k forks source link

Television Microphones #12022

Open Streaky-Haddock opened 1 year ago

Streaky-Haddock commented 1 year ago

The regular television microphones have two minor issues that are livable, but should be mentioned.

1) The Microphones cannot distinguish between solid walls and windows. So someone on 1 side of a narrow window will not be picked up by the camera, which may make courtrooms tricky. However it might be more effort than it's worth fixing, given there are reasons to NOT have microphones pick up speech on the other side of a wall/window.

2) Televisions, if there are multiple, will spam the local speech channel. Not a problem except for ghosts and admins. So having them be filterable would help.

Overall, I love the addition, though I wanted to flag these up on the off-chance they are easily fixable and not intentional

ElectroJr commented 1 year ago

Speech doesn't have any sort of audio occlusion logic. The unobstructed checks for TV & hand-held radios are pretty arbitrary. For now its probably better to at least make them work consistently with how voice works (i.e., just a range check) and let someone figure out audio occlusion for speech sometime later. I'll update #11980 to do that.

In terms of not spamming chat, I can just disable chat logging for them, so that they only appear as pop-ups in game?

Streaky-Haddock commented 1 year ago

That can help. Another thing that can help if allowing the Reporter to toggle it on and off so he's not broadcasting while moving. After playing a round of Reporter, most people turn it off because it spams chat.