space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.53k stars 3.13k forks source link

AtmosPipeColor stuff should just be prototypes #13068

Open metalgearsloth opened 1 year ago

metalgearsloth commented 1 year ago

It's at least 5,000+ wasted yaml lines per high-pop map.

Cheackraze commented 1 year ago

Do you want all the used colors to be prototypes? So teal, blue, red, brown, purple? And for vents, passive vents, mixers, filters, pumps, volume pumps, valves, passive gates, scrubbers, injectors, pneumatic valves, etc? Because that's gunna make the entity list absolutely balls to work with for atmos devices

moonheart08 commented 1 year ago

Yea, no, Vera, me, and probably every mapper do not want this. Heavily bloats the entity list, makes mapping more of a pain, etc.

ElectroJr commented 1 year ago

Bloating the entity list & making mapping a pain seems like its more of a mapping tools issue, so if anything this should probably just be deferred until better pipe colouring support is added? Because it is still true that this just bloats map files & should probably be using prototypes if possible.

metalgearsloth commented 1 year ago

Yea, no, Vera, me, and probably every mapper do not want this. Heavily bloats the entity list, makes mapping more of a pain, etc.

We will make the tooling better before doing it but don't close performance issues.

IProduceWidgets commented 3 months ago

If this is done, please make sure you come up with another way to check if a grid has disconnected networks, because the way it currently works the command colornetwork is the only sensible way to do that.