search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.com
MIT License
2.75k stars 3.49k forks source link

Make links to github in copyright more direct #13381

Open AJCM-git opened 1 year ago

AJCM-git commented 1 year ago

Description

Our current way of linking copyright can be improved a lot, currently most RSIs just link to a commit which most of the time doesn't include the files at hand directly because the author took the latest commit in the repository instead of the one in the file history, so you have to dive in the commit and search for the file. The attribution is given correctly like this but the process to check that takes a lot of time, specially when you don't know the exact location of a sprite, and honestly i wouldn't be surprised if some things slipped under the radar like this. Now, even if the commits included the files this still sucks because then the files can (and often are) be buried in a sea of changes, and depending on how big the change is it might not even render in the github UI.

This is why im proposing we start linking the blob/tree of the file/folder instead. For example, if i take many sounds from the voice folder of goonstation, i can do it in the obtuse, current, way of linking a commit with a gazillion changes like this https://github.com/goonstation/goonstation/commit/4059e4be90832b02b1228b1bee3db342094e4f1e and then a maintainer has to either trust im competent and act in good faith or go themselves and dive in that commit for who knows how long searching for the sprites. Or i can link the folder directly at a commit like this https://github.com/goonstation/goonstation/tree/4059e4be90832b02b1228b1bee3db342094e4f1e/sound/voice/ which gives maintainers and anyone interested in knowing the copyright direct access immediately

The only con i see is obviously converting the thousands of old copyrights is a pain, but we could at least start asking for this when reviewing while slowly transitioning.

metalgearsloth commented 1 year ago

This doesn't really work if the rsis are sourced from multiple files.

AJCM-git commented 1 year ago

then RSIs just need to support multiple sources Then thats a special case that needs handling, in cases like that going by the common path of the files would be the best i think, if it happens to be icons/ or the commit itself then so be it, but not that many RSIs have this problem from what i've seen