space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.53k stars 3.12k forks source link

Bicaridine Bug #14197

Open Limesly opened 1 year ago

Limesly commented 1 year ago

Description

It looks like certain medicines, such as Bicaridine, aren't doing their job as expected. From the data on the wiki, Bicaridine should heal 4 Brute per Unit, however my testing shows it heals about 1.2 Brute per Unit. I've checked the change logs and github, and it seems like this is unintended, though I could be wrong and I'm sorry if this was intentional and I'm just wasting time. This also seems to be affecting other chemicals though I haven't had time to test them yet. I think it might affect chemicals that stop bleeding. It also appears to affect Cryoxadone, almost making it worthless to use as the Cryo Pod out damages its healing effect.

Reproduction

Produce Bicaridine or another chemical designed to heal a damage type. Get damaged and then use that chemical to heal that damage. Take note of how much it heals and then compare to how much it should heal.

Screenshots

In this first image, I had 84 Blunt damage. I was playing on my own server that I updated today, so all the code should be up to date. I did this in my own admin testing arena, but it doesn't seem to be any different elsewhere. I also ran this test on Nyanotrasen Io, with no differences in the numbers. image In this second image, I had consume 2 pills for a total of 30u of Bicaridine, and then took the image after the healing effect stopped. The amount it should've healed was 120; it only healed 36.58. image

Additional context

I'm not fully sure if I've done something wrong which caused this, or if the data on the wiki is out of date, or if I'm somehow miscalculation and this is how much damage its always healed, but from my experience I don't think any of that is the case. Hopefully you guys find this helpful. More testing might need to be done to see if it affects other chemicals.

Limesly commented 1 year ago

This also affects Tricordrazine, I'll make a spreadsheet to show what the healing to units are like per medicine.

deltanedas commented 1 year ago

they are working as intended, just it's not clear how it's intended they heal max N damage per unit per group so if you take 25u derma and have 90 heat damage, it will only heal 50 of it since thats 2/6 but if you have 90 burn damage spread evenly it will heal all of it.

Limesly commented 1 year ago

image image image image So you're right, and I got confirmation that it has always been this way, however Bicaridine is in fact healing less than 4/3rds per type, its current speed is 1.2 per type. We should also update the wiki https://wiki.spacestation14.io/wiki/Medical#Brute_damage

deltanedas commented 1 year ago

possibly a fixedpoint2 rounding error but not sure

UbaserB commented 6 months ago

Is this still happening?