Backpack cake overfill bug

[MrBirdmann]

Found a way to fill a backpack over its maximum capacity.

Reproduction:

• Fill a container with cakes (I used cakes and and an emergency box, I'm assuming this would work with any sliceable item and any container that can be placed inside a backpack)
• Put the container inside your backpack
• Slice the cakes, the cake slices will magically disappear
• Remove the empty container from your backpack
• Huzzah! ALL the slices will reappear inside you backpack, even if there wasn't enough space for them

Don't know how the underlying mechanics of this work but it seems that increasing the cake's size to match the sum of the slices would prevent this from happening.

[juliangiebel]

The size of the cake and the sum of the slices should probably match yea

[hsagerer]

I'd like to tackle this if possible. I was unable to recreate the bug exactly, as I couldn't get a box into a backpack. What box were you using exactly, and what backpack? The sizes weren't working out.

My first idea of a fix was to increase the size of a cake to 25, and have it reduce in size by 5 every time a slice is taken from it.

[hsagerer]

I've adjusted the cake to have a size of 25, which makes it so it has the same size as the sum of all slices. This does not seem to fix the underlying bug fully, but is a start. I tried to implement having the cake reduce in size as slices are taken, which works, but this introduces a new bug where the size is not updated if you slice the cake in a backpack.

[deltanedas]

thats not really a new bug its pretty old and happens to a few things, including headsets

[hsagerer]

This pull request fixes the issue where cake and cake slices do not add to the same amount, and includes commented out code for decreasing the size of a sliceable food when it is sliced. This issue is partially fixed, but the code for decrementing size could still be added with further testing.

[deltanedas]

somewhat related to wire stack size increasing/decreasing the item size