space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.74k stars 3.48k forks source link

Logs should use tags not single types #16953

Open Chief-Engineer opened 1 year ago

Chief-Engineer commented 1 year ago

Description

Logs currently use log types. Each log can be one type. To allow better filtering, each log should be able to have multiple tags.

Some log types fit into categories, like hit logs. Having a shared tag for these would be helpful for when admins try to figure out who attacked people. Ahelps don't usually specify, so admins need to either ask or select all 3 log types in the filter. While selecting 3 log types doesn't take a long time, it'd be a minor QOL change and the time savings would add up.

Some log types group a system/item, like RCD, while others group in-game results, like Construction/EntityDelete. Neither is best in all cases and having both will result in some overlap. Tags allow both types to be used in logs, allowing admins to use whichever is best in the situation.

Scenario

A wall is missing into the armory, an admin wants to figure out who took it down. They don't have the entity uid for the wall because the wall doesn't exist anymore and there are too many walls on the station to just search the prototype.

Currently

An admin has to know every log type that may log a deletion/deconstruction in addition to EntityDelete, filter by those and search the wall prototype, then sift through logs that are unrelated to deletions, because types like RCD will log creations of walls too.

Tagged system

An admin can filter to only EntityDelete which would include every log that results in a deletion of an entity, then search the wall prototype. There would still be logs for deletions of other walls, but every log would be a deletion of a wall.

Other Examples

juliangiebel commented 1 year ago

I already fear the massive migration and index building 😰 I definitly agree though

PJB3005 commented 1 year ago

The entire storage method for admin logs probably needs to be rethought anyways.