search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.63k stars 3.3k forks source link

Pump/bolt actions not working #19250

Open liltenhead opened 1 year ago

liltenhead commented 1 year ago

Description

Guns like the kammerer and mosin no longer need to be pumped or bolted. They are essentially semi auto guns now.

Reproduction Pick up one of the guns and just keep clicking.

Screenshots https://youtu.be/6uWch1mTar4?t=154

SpeltIncorrectyl commented 1 year ago

No idea how it was pump action in the first place (the Kammerer), in shotguns.yml it inherits from this BaseWeaponShotgun that has been set to semi automatic for atleast a year (latest change to the selectedMode field was a year ago in #8301).

- type: Gun
    fireRate: 2
    selectedMode: SemiAuto
    availableModes:
    - SemiAuto
    soundGunshot:
      path: /Audio/Weapons/Guns/Gunshots/shotgun.ogg
    soundEmpty:
      path: /Audio/Weapons/Guns/Empty/empty.ogg

How long ago was it pump action?

liltenhead commented 1 year ago

Uhh before the bolt PR so very recently.

SpeltIncorrectyl commented 1 year ago

Found a version of the repo before the pull request merged https://github.com/TaralGit/space-station-14-Taral/commits/master (this is the fork that was merged in pr #17219, a different branch without the bolt changes), cloned it and built it and the Kammerer works correctly. Need to figure out what caused it to break.

SpeltIncorrectyl commented 1 year ago

I believe I've figured out what it is, the BallisticAmmoProvider lacks the autoCycle: false property.

code before pr (working)

- type: BallisticAmmoProvider
    autoCycle: false
    whitelist:
      tags:
      - ShellShotgun
    capacity: 7
    proto: ShellShotgun
    soundInsert:
      path: /Audio/Weapons/Guns/MagIn/shotgun_insert.ogg

code after pr (broken)

- type: BallisticAmmoProvider
    whitelist:
      tags:
      - ShellShotgun
    capacity: 7
    proto: ShellShotgun

It's straight up been removed, dunno how this could have happened.

SpeltIncorrectyl commented 1 year ago

The AutoCycle property is missing from the new BallisticAmmoProviderComponent.cs, not just the yaml.

SpeltIncorrectyl commented 1 year ago

Fixed it, now I just gotta find and change the yamls of the shotguns and bolt actions back to having autoCycle, then I can submit a pr.