space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.72k stars 3.44k forks source link

Storage feedback #21248

Closed metalgearsloth closed 3 months ago

metalgearsloth commented 1 year ago

Gather feedback and what needs changing, i.e. UI / sizing / code / whitelists.

spectralSpices commented 1 year ago

Well, I'll hit the basic ones I've seen mentioned-pills and handguns take up the same amount of space, and people are fitting hardsuits into bags, which seems like an issue. As is, I think having nested storage as the go-to is allowing stuff like people fitting 42 C4 into a single duffel or tossing an entire engineering department's hardsuit count into one.

keronshb commented 1 year ago

Feedback

UI

Sizing

Code

Whitelists

Medium/Large Guns

Bugs

UI

image Long names extend into the size descriptions

Sizing

Code

Whitelists

N/A

Cheackraze commented 1 year ago

incredibly poorly implemented, exacerbates every single issue that it sought to resolve, increases the maintenance and balance across literally thousands of entities, was incredibly rushed, no feedback was implemented, and causes almost the entirety of the game's systems to become unbalanced.

forcing a resource scarce modeled inventory system in a resource rich paradigm of game design, the two are fundamentally incompatible and will just cause an endless amount of pain to bring anywhere close to a 'balanced' or even enjoyable to play state. Should be immediately reverted until a more well thought out and actually thought out and planned system can be designed, not this rushed disaster.

metalgearsloth commented 1 year ago

Should be immediately reverted until a more well thought out and actually thought out and planned system can be designed, not this rushed disaster.

Don't post garbage, didn't think I'd have to state in the OP.

Cheackraze commented 1 year ago

Should be immediately reverted until a more well thought out and actually thought out and planned system can be designed, not this rushed disaster.

Don't post garbage, didn't think I'd have to state in the OP.

excuse me? Are you actually wanting feedback or no?

Cheackraze commented 1 year ago

Why is my comment marked as off topic? I am giving legitimate critique to the system as a whole. If anyone would like to actually discuss the merits of it, or any points I have made, I am open to having this conversation. For the sake of it, here are the points I expressly made about the system:

  1. incredibly poorly implemented
  2. exacerbates every single issue that it sought to resolve
  3. increases the maintenance and balance across literally thousands of entities
  4. was incredibly rushed
  5. no feedback was implemented, and
  6. causes almost the entirety of the game's systems to become unbalanced.

I understand that these are high level concepts and not low level specifics, however they are in earnest and have yet to be adressed.

Carolyn3114 commented 1 year ago

guns/bags/hardsuits/large jetpacks shouldn’t be able to fit in bags (or at least, should take up 6-7 space) guns and stuff shouldn’t be able to fit in belts (or again, should take up more space in the belts) other than that, with this, and the “only one inventory at a time” PR, I think there should be a hud rework that makes the bags look more like how modern goonstation/tg have them

metalgearsloth commented 1 year ago
  1. Untrue, it barely changed storage system.
  2. You need to explain your points not handwave it.
  3. No it doesn't. 5 sizes is less than dozens.
  4. No it wasn't.
  5. Untrue but you're discord banned so can't read it.
  6. This is just useless hyperbole.

This is not an issue to continue spinning in circles and is to address what needs changing.

Cheackraze commented 1 year ago
  1. Untrue, it barely changed storage system.

    1. You need to explain your points not handwave it.

    2. No it doesn't. 5 sizes is less than dozens.

    3. No it wasn't.

    4. Untrue but you're discord banned so can't read it.

    5. This is just useless hyperbole.

This is not an issue to continue spinning in circles and is to address what needs changing.

Ok, so not only have you not adressed a single critique, you're bringing straight irrelevant and harassing language into it?

Im trying to legitimately give criticism to the system and you are just trolling, Please engage in appropriate, on-topic discussions

DrSmugleaf commented 1 year ago

Why is my comment marked as off topic? I am giving legitimate critique to the system as a whole. If anyone would like to actually discuss the merits of it, or any points I have made, I am open to having this conversation.

@Cheackraze It was marked off-topic because of its needlessly confrontational language, feedback without it is fine. incredibly poorly implemented, exacerbates every single issue that it sought to resolve for example is confrontational and hyperbolic, as is was incredibly rushed, no feedback was implemented and Should be immediately reverted ... not this rushed disaster. "I don't think it correctly addresses the issues it sought to resolve" would be fine, as would "there wasn't enough time for all the feedback to be addressed". This issue will have feedback that one or more contributors will have to read through to improve and change the system, and they have no obligation to reading comments that will make them uncomfortable doing so. If you are looking to get their feedback addressed by them, do so in a neutral tone.

Im trying to legitimately give criticism to the system and you are just trolling, Please engage in appropriate, on-topic discussions

You are not giving legitimate criticism, you are leaving inflammatory comments that bait people into answering to them. Stay civil or you will be repo banned. This is your last warning.

DrSmugleaf commented 1 year ago

@Cheackraze to correct the post above, seeing as you are not interested in honest and civil dialogue while engaging in spreading misinformation, you are now repobanned: image

image

Anyone is welcome to leave feedback as long as they are civil in doing so. You can appeal on the forums when you feel it is appropriate.

Interrobang01 commented 1 year ago
this reply is collapsed so i don't get yelled at, i forgot why i wrote this but I think it's important and now i've spent more time apologizing for my shortcomings than actually fixing them, i apologize Suggested solution: get rid of nested storage; increase storage size of bags to make up for it The core assumptions of this argument are that the problems I'm gonna mention are actually problems. I can't argue backwards forever, so arguments as to why these are problems shall be left as an exercise to the reader. I acknowledge that that's really scummy, sorry. The problems this solution tackles: 1. Nested storage makes everything unfun 2. Everything takes up 1 slot which is goofy (i acknowledge that emogarbage just made a pr that addresses this) 3. Storage systems matter too much, which detracts from all the other gameplay Suggested implementation: - Make all storage objects take up a number of slots equal to their capacity (so a box takes 7 slots instead of 1) - Increase backpack (and belt?) storage to like 20 slots How this will fix outlined problems: 1. By axing nested storage, it stops being unfun because it doesn't exist anymore. The lost storage capacity is made up for by increased bag capacity. 2. Since bags now have an absurd number of slots, this doesn't matter any more. Sure, you could make arguments that now 20 paper uses as many slots as 20 L6 saws, but where are you even getting 20 L6 saws or 20 paper? All comparisons stop being realistic. The unrealisticness of these hypothetical scenarios translates into realisticness of the system. 3. Bags now have so many slots that people will rarely actually fill them, meaning no more storage gameplay (good) Counterclaims and Countercounterclaims (there should be more of these, whoops): CC1. Now you can fit like 20 laser rifles in a bag, far too much CCC1: In this hypothetical scenario where someone has 20 laser guns and is hauling them around in a bag, the thing to rebalance away is the person getting 20 laser rifles (also with current implementation you can already carry 20 laser guns, just use a locker). That doesn't solve everything though, so as a bonus you could make guns not fit in packs and start leaning into suit storage-like systems. It's late so I won't be able to reply to this for a while. Also, I spent so long organizing this that I'm not even sure if this is a good solution anymore. I also forgot why I'm writing this reply in the first place. Crap, just get this thing out of my sight, I'm done with this, (author's note: that last line was written 20 minutes ago)
MagnusCrowe commented 1 year ago

@Interrobang01 Have you considered what your proposition might mean for scenarios involving specialized containers like pill bottles, for example?

Wouldn't what you suggest have a pill bottle take up 9 slots, same as a crowbar, a laser rifle, a coil of LV wire, a jug of bicar, an oxygen tank, a mouse, a flashlight, a lamp, and a pair of handcuffs? All to contain 9 itsy bitsy pills?

Apologies if I misread your post.

deltanedas commented 1 year ago

Make all storage objects take up a number of slots equal to their capacity (so a box takes 7 slots instead of 1)

this is pretty much just numerical size :trollface:

idea i have for making it better is each storage has a number of slots for each item size so say a box can hold 4 small and 5 tiny items or something, you can put more pens in it at no cost to the other contents this would also translate to bags, say 1 large 3 medium 6 small 10 tiny then duffelbag has more slots + shifted upwards so its more focused on extra large/medium slots, if you want to store random shit in a duffel put it in a box first. this would solve putting 20 lasers in a bag since you can only fit 1/2 depending on duffel or not.

yaml implementation would be like this

- type: Storage
  sizes:
    large: 1
    medium: 3
    small: 6
    tiny: 10
deltanedas commented 1 year ago

that or just use stalker inventory where unlimited volume but you get slowed down by weight and eventually cant move when at 70kg load :trollface:

BlitzGunner225 commented 1 year ago

So imma add my 2 cents into the mix

Actual problems with old storage

  1. Boxes such as the emergency box weight is static and always more than what it can contain, meaning it’s an absurd waste of space. Perhaps having it as 15 and then increase to the weight of items inside if above.

  2. UI is absurdly huge and is annoying to organize on you screen. Solutions are letting ui boxes magnetize to each other, the choice to make items inside ui appear in a grid system with only sprites until hovered over, and magnets for the corners of the screen for ui boxes

  3. Whitelists require specific items to be written rather than groups and it could use more whitelist options. Could have the ability to whitelist items only under a specific folder and a unwhitelist by default in item scripts.

  4. Storage number info takes priority over items in ui when shrinking vertically and wastes space for containers that only have 1 or 1 type of item. Could fix by having the items take priority when under those conditions or an option to disable.

That’s all I can think of in 10 minutes and it seems not a single one was fixed. The new system instead attempts to minimize the amount of items in belts, which has never been a problem, makes precise balancing harder by restricting storage numbers to a smaller and more preset amount, and adds the new problem that storage is extremely abuseable with extra containers in containers.

I feel next time that major changes like these should be shared at the concept stage so it can be shut down and people can move on rather than misuse people’s time in case it ends in community uproar as this new system seems to have done.

keronshb commented 1 year ago

This is based from the newest PR #21373

I'll be posting in different parts as I discover more issues, balancing or otherwise.

Engineering

image

It becomes difficult trying to repair the station if you can't carry what you need on you. Engineers need to be able to move quickly so duffels are usually out of the question because they can slow you down (on top of hardsuit slowdown).

Security

image

Overall security storage is ok at best and you shouldn't be able to fit an entire armory on you at once, but you also shouldn't be able to fit an entire armory's worth of disablers/tasers on you. You also need more places to store your armmo as needed.

Nukies

image

Nukies have a decent amount of room for their loadouts, just some small things to change here.

A note on traitors: Same issue as engie, sorta? Just make sure they can have enough of a loadout + be able to safely carry steal items.

Plant/Ore Bags

image

I feel these should stack but also look how many gatfruit you can carry in one plant bag (not even full yet)

Heads/Captain

image

Assuming the captain doesn't take their jetpack with them, it's really hard to carry the basics & have room for other potential items (food, drink).

Misc

image image

image

Summary

This is at a better place but there's still areas that can be improved such as:

deltanedas commented 1 year ago

bruh why is antique laser same size as a flash

metalgearsloth commented 1 year ago

@BlitzGunner225

That’s all I can think of in 10 minutes and it seems not a single one was fixed. The new system instead attempts to minimize the amount of items in belts, which has never been a problem, makes precise balancing harder by restricting storage numbers to a smaller and more preset amount

Whitelists require going through and manually removing them when we find something we're happy with obviously. Precise balancing is an oxymoron considering numbers were largely random and not consistent.

I feel next time that major changes like these should be shared at the concept stage so it can be shut down and people can move on rather than misuse people’s time in case it ends in community uproar as this new system seems to have done.

It was, on discord, hence the discussion around "let's try it and see what works" not "let's never change anything". If you were still there you'd also see gridventory is going to get tried.

BlitzGunner225 commented 1 year ago

If you were still there you'd also see gridventory is going to get tried.

To clarify what I said would only affect visuals and not mechanics

Saying no one balances precisely does not take into consideration future servers, future proofing, and still factually removes customizability which is bad (there is a reason most games use 100 hit points rather than 10).

Also talking about a game changing feature in a space where like half of the fork owners CAN’T see it is unhealthy for the community. That also doesn’t include the players banned who play the game on other branches and are by definition apart of the community.

BlitzGunner225 commented 1 year ago

Ah a new 4th edition

well it does feel better to the point that it’s mildly acceptable, it still feels like a downgrade and it does not fix any of the big problems with inventory. Packs are essentially back to how they were before storage wise. Belts/slots are limiting due to decreasing the storage balance variables (item weight, pack capacity, and pack movement speed) from 3 to 2 and was never a problem with whitelists and the storage number. Item balance, while now containing multiple presets rather than one is still more restricted in balance. You could just keep the high/flexible values, keep the idea of multiple presets or list them in a public game design doc, and get rid of the limiting slot system.

It just feels a bit pointless putting in so much effort to get a feature to work that most people weren’t complaining about rather than extremely important features such as mind and surgery. m

deltanedas commented 1 year ago

extremely important features such as mind and surgery.

both of which are being worked on :trollface:

BlitzGunner225 commented 1 year ago

extremely important features such as mind and surgery.

both of which are being worked on :trollface:

And have had little to no progress over the past 2 years

EmoGarbage404 commented 1 year ago

And have had little to no progress over the past 2 years

Every single person who works on this project is an unpaid volunteer working out of their own volition, as a hobby. There are no professional studios or companies behind the project, we are just a group of people passionate about game development. As such, not a single one of us is forced to unwillingly contribute our time to Space Station 14, we all have a life. Most of us have a job or studies, and all of us contribute to this project in our free time.

In short, nobody is obligated to work on any feature, regardless of how urgent or important you or anyone else thinks it is. If you want it, you are perfectly capable of creating it and submitting a pull request yourself.

BlitzGunner225 commented 1 year ago

And have had little to no progress over the past 2 years

Every single person who works on this project is an unpaid volunteer working out of their own volition, as a hobby. There are no professional studios or companies behind the project, we are just a group of people passionate about game development. As such, not a single one of us is forced to unwillingly contribute our time to Space Station 14, we all have a life. Most of us have a job or studies, and all of us contribute to this project in our free time.

In short, nobody is obligated to work on any feature, regardless of how urgent or important you or anyone else thinks it is. If you want it, you are perfectly capable of creating it and submitting a pull request yourself.

I know that this is volunteer work but I’m saying that rather than people putting so much effort into their own content, even against most of the community’s wishes, that they should maybe instead think about everyone else and maybe work on the stuff that needs to get done.

mirrorcult commented 1 year ago

I know that this is volunteer work but I’m saying that rather than people putting so much effort into their own content, even against most of the community’s wishes, that they should maybe instead think about everyone else and maybe work on the stuff that needs to get done.

If you want it, you are perfectly capable of creating it and submitting a pull request yourself.

LordEclipse commented 1 year ago

And have had little to no progress over the past 2 years

Every single person who works on this project is an unpaid volunteer working out of their own volition, as a hobby. There are no professional studios or companies behind the project, we are just a group of people passionate about game development. As such, not a single one of us is forced to unwillingly contribute our time to Space Station 14, we all have a life. Most of us have a job or studies, and all of us contribute to this project in our free time. In short, nobody is obligated to work on any feature, regardless of how urgent or important you or anyone else thinks it is. If you want it, you are perfectly capable of creating it and submitting a pull request yourself.

I know that this is volunteer work but I’m saying that rather than people putting so much effort into their own content, even against most of the community’s wishes, that they should maybe instead think about everyone else and maybe work on the stuff that needs to get done.

That encourages toxic behavior. If you are coding for free, Why should you be forced to acquiesce to people's requests or demands just because you took the time and effort to learn how to code, and they didn't?

BlitzGunner225 commented 1 year ago

And have had little to no progress over the past 2 years

Every single person who works on this project is an unpaid volunteer working out of their own volition, as a hobby. There are no professional studios or companies behind the project, we are just a group of people passionate about game development. As such, not a single one of us is forced to unwillingly contribute our time to Space Station 14, we all have a life. Most of us have a job or studies, and all of us contribute to this project in our free time. In short, nobody is obligated to work on any feature, regardless of how urgent or important you or anyone else thinks it is. If you want it, you are perfectly capable of creating it and submitting a pull request yourself.

I know that this is volunteer work but I’m saying that rather than people putting so much effort into their own content, even against most of the community’s wishes, that they should maybe instead think about everyone else and maybe work on the stuff that needs to get done.

That encourages toxic behavior. If you are coding for free, Why should you be forced to acquiesce to people's requests or demands just because you took the time and effort to learn how to code, and they didn't?

I’m not saying to force people, just recommending that they look at the bigger picture. Also some are considering the extreme push to get the new system to work, against most of the community’s wishes, as being a bit toxic.

BlitzGunner225 commented 1 year ago

I know that this is volunteer work but I’m saying that rather than people putting so much effort into their own content, even against most of the community’s wishes, that they should maybe instead think about everyone else and maybe work on the stuff that needs to get done.

If you want it, you are perfectly capable of creating it and submitting a pull request yourself.

I’m busy trying to figure out College now that I’m in it.

retequizzle commented 1 year ago

And have had little to no progress over the past 2 years

Every single person who works on this project is an unpaid volunteer working out of their own volition, as a hobby. There are no professional studios or companies behind the project, we are just a group of people passionate about game development. As such, not a single one of us is forced to unwillingly contribute our time to Space Station 14, we all have a life. Most of us have a job or studies, and all of us contribute to this project in our free time. In short, nobody is obligated to work on any feature, regardless of how urgent or important you or anyone else thinks it is. If you want it, you are perfectly capable of creating it and submitting a pull request yourself.

I know that this is volunteer work but I’m saying that rather than people putting so much effort into their own content, even against most of the community’s wishes, that they should maybe instead think about everyone else and maybe work on the stuff that needs to get done.

That encourages toxic behavior. If you are coding for free, Why should you be forced to acquiesce to people's requests or demands just because you took the time and effort to learn how to code, and they didn't?

I’m not saying to force people, just recommending that they look at the bigger picture. Also some are considering the extreme push to get the new system to work, against most of the community’s wishes, as being a bit toxic.

That's a "them" issue tbqh, they are invited to the same opportunity that was presented to you and can PR things they would like to have done themselves if they are not satisfied with waiting.

At this point, the heckling over what features do or do not get added needs to stop, especially when a decent proportion of the heckling/complaining/bitching is coming from people who don't actively contribute anything to the project.

BlitzGunner225 commented 1 year ago

That encourages toxic behavior. If you are coding for free, Why should you be forced to acquiesce to people's requests or demands just because you took the time and effort to learn how to code, and they didn't?

I’m not saying to force people, just recommending that they look at the bigger picture. Also some are considering the extreme push to get the new system to work, against most of the community’s wishes, as being a bit toxic.

That's a "them" issue tbqh, they are invited to the same opportunity that was presented to you and can PR things they would like to have done themselves if they are not satisfied with waiting.

At this point, the heckling over what features do or do not get added needs to stop, especially when a decent proportion of the heckling/complaining/bitching is coming from people who don't actively contribute anything to the project.

Dude some people don’t have the time to learn how to code and shouldn’t be forced to as some sort of right of passage. I agree some people can get a bit toxic but there are plenty offering actual valid criticisms that should be listened to. And while you don’t need to follow what people say but in scenarios like these where I’ve only found backlash, maybe you should rethink this stuff back to foundation to find out what it all means.

EmoGarbage404 commented 1 year ago

i genuinely can't believe you're still rattling on about this trite shit so let me just spell it out clearly for you so you can understand why your point is dumb.

abso-fucking-lutely no one on the entire project is entitled to code anything. Not a single person here is operating on any kind of schedule or mission or goal that is in any way distinct from their personal vision of what they want to do for the project.

Sorry to break this down for you but this feeling you have that the people should be focusing on "the bigger picture" in terms of some kind of development roadmap is quite simply just entitlement. If a person isn't working on it, it's because they don't want to and that's 100% okay. So please, kindly, shut up about this "big picture" high horse that you feel the need to preach about. Especially considering your last contribution to the repository was literally over a year and half ago, I don't really think you have a good picture of what would be best for the overall big-picture development of the game.

Whinging aside:

Dude some people don’t have the time to learn how to code and shouldn’t be forced to as some sort of right of passage.

Dunno how to spill this one to you other than this: a sizable amount of the people contributing to this project have no prior experience developing games or even coding at all. Many frequent contributors don't even code, choosing instead to use YAML markup to add assets or to contribute art or maps to the game.

Putting in the time to help is the mark of a contributor: it is a literal, tangible embodiment of the work that a person has put into the game. It is a mark of knowledge, experience--and most of all--dedication to a community to put in the effort to be able to contribute to a larger whole. There is a reason that the people who put in the effort to do so are more respected and held to a higher standard.

but there are plenty offering actual valid criticisms that should be listened to

I don't know why people keep going on about this but i'll just clarify this real fucking cleanly:

I get that you're not in the discord but i'm not sure why you're acting like there's some kind of oligarchy choosing how this gets done.

against most of the community’s wishes

You seem to have this strange illusion that space station 14 is, as a whole, a democratically made game, wherein every player should have their input voted up like some kind of Athenian election. The reality is that while players' feedback is an important cycle that is consistently and frequently taken into account in terms of balancing and refining mechanics to be palatable, players are not the ones choosing what is being added or removed from the game.

The game exists as it is due to the consistent work of the many individuals who have contributed to the project while ultimately being shaped by the maintainer team, who diligently work to keep the game and project running. These aren't closed doors, but there is a barrier to entry; a barrier defined by the dedication and work that our contributors invest in the project. These people with the skills to build, reinvent, and support the game are the ones who shape it, wholly separate to the opinions of those who did not imbue themselves in the creation of this big hunking project that we all care about.

so would you kindly stop flooding this damn thread with pointless whinging? thanks.

deltanedas commented 1 year ago

19:38:50

:trollface: empty susbox (mapper only???) gets 1 less slot susbox can hold 7/8 pneumatic cannons which can old 8 normals items :trollface:

deltanedas commented 1 year ago

combat medkit is normal 15:22:22

possible fix is making it large and giving agent chest rig whitelist + max item size large

slarticodefast commented 3 months ago

Considering that we now have gridstorage making this discussion about the old system obsolete I think this issue can be closed.