space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.com
MIT License
2.75k stars 3.49k forks source link

Fax mail can be took from behind the wall #25110

Open Lukasz825700516 opened 9 months ago

Lukasz825700516 commented 9 months ago

Description

Fax machines put printed mail slightly inside the tile above them, making it possible for mail to be taken from behind the wall by anyone accidentally.

Reproduction

  1. Put paper into fax
  2. Send fax to fax with wall one tile above it
  3. Try taking the mail from the other side of the wall
  4. Discover all NT secrets

Screenshots

https://github.com/space-wizards/space-station-14/assets/38139742/4941f341-39e3-494c-8445-cd9b36111dc8

Additional context On Packed it is possible to accidentally take some mail from HoP

Lukasz825700516 commented 9 months ago

https://github.com/space-wizards/space-station-14/blob/0071b095abe477b23546bd3ea86d6c13ba6e4acf/Content.Server/Fax/FaxSystem.cs#L508

Ok, it seems like the mail is just pushed into the wall through collision with the fax machine, as I cant find any position offset for new mail to spawn.