space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.11k stars 2.79k forks source link

Reagent code issues #26739

Open QuietlyWhisper opened 2 months ago

QuietlyWhisper commented 2 months ago

While looking at the issue with tricordrazine, we found similar code issues with the iron reagent

Related to #26618

Maints can read more specifics @ https://discord.com/channels/310555209753690112/1193403928096821358/1224899739905163357

SlamBamActionman commented 2 months ago

For the second bulletpoint, this could be/is intended. The lineup of specialized Brute meds work specifically because Bicardine splits its healing across the various damage types.

While I am not opposed to reworking the meds to be more reliable it might also be a guidebook issue. It's really not obvious that "Heals 3 Brute" or "Heals 3 Heat" do not equal the same individual heal amounts.

K-Dynamic commented 2 months ago

While I am not opposed to reworking the meds to be more reliable it might also be a guidebook issue. It's really not obvious that "Heals 3 Brute" or "Heals 3 Heat" do not equal the same individual heal amounts.

It's misleading since it's basically a hidden mechanic

(Also I'm not sure if I ever came across a 'heal X heat' statement for most meds because caustic is part of heat - so it's weird heat meds heal all other heat damage equally, as though it's a description issue)

QuietlyWhisper commented 2 months ago

For the second bulletpoint, this could be/is intended. The lineup of specialized Brute meds work specifically because Bicardine splits its healing across the various damage types.

While I am not opposed to reworking the meds to be more reliable it might also be a guidebook issue. It's really not obvious that "Heals 3 Brute" or "Heals 3 Heat" do not equal the same individual heal amounts.

If this was intended, I'd mark it as a balance issue because a lot of chems are underpowered due to it, they should at minimum split into the existing damage types and not just waste away. Tricordrazine is ridiculously underutilised due to it's chemical cost not being worth less than 1 point of healing per unit for single damage types.

QuietlyWhisper commented 2 months ago

It's misleading since it's basically a hidden mechanic

It's also extremely misleading in the guidebook, yes. Even more so when you consider that because reagent scaling is also borked, the healing value it per metabolism tick rather than per unit. I.e 0.5 = 1u of effect in most chems