space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.53k stars 3.13k forks source link

Clown shoes waddling animation bugs out when slipping #26950

Open Killerqu00 opened 4 months ago

Killerqu00 commented 4 months ago

Description

If you slip in clown shoes, you do not actually look like you slipped. Instead, you waddle in place.

Reproduction

  1. Wear clown shoes
  2. Slip yourself

Screenshots

https://youtu.be/fcd6ShpTZGk

Additional context

dragonryan06 commented 4 months ago

These shoes are the buggiest thing in the game right now I don't even understand how this PR made it through

image

Even a dead clown wearing clown shoes will dance around if buckled to a bed.

The walk-detection being used to stop the animation is also very imperfect, and often times while standing still the animation will continue.

I really like the idea, but please test your code before submitting it!!

superjj18 commented 4 months ago

I really like the idea, but please test your code before submitting it!!

You clicked “join playtest” when you downloaded the game, we ARE testing their code :trollface:

FairlySadPanda commented 4 months ago

Pretty much, especially because getting this working involves bolting the animation on top of empty space - there's no animation state machine for mob movement and no cohesive mob start/stop moving event system.

Reporting bugs means they get fixed