search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.53k stars 3.13k forks source link

State 'trinkets-equipped-INNERCLOTHING' not found in RSI: '/Textures/Clothing/Uniforms/Jumpsuit/cargotech.rsi' #27366

Open Mirino97 opened 4 months ago

Mirino97 commented 4 months ago

image

hitomishirichan commented 4 months ago

we've poked around in the code and the way it seems...colored jumpsuits, including prisoner jumpsuits are actually built in two layers, the base colored layer, and the uncolored things such as the belt and zipper and such that's on top of that. that upper layer is the trinkets-equipped layer and its only ever referenced in correlation with the colored jumpsuits and we couldn't actually find any overlap that would make the cargo tech jumpsuit be treated like a colored jumpsuit on spawn which means that it has to be some sort of weird interaction...after testing with the chameleon jumpsuit, which seemed like the most likely culprit, we were able to recreate the error after switching from a colored jumpsuit to a cargo jumpsuit and we're seeing if we can fix it

hitomishirichan commented 4 months ago

update:

what the FUCK this is such a rabbit hole 🐇

hitomishirichan commented 4 months ago

beginner friendly they said

difficulty 1 easy they said

image

ZombieChibiXD commented 4 months ago

Content.Client/Clothing/ClientClothingSystem.cs#L273-L336 needs rework to fix bug

https://github.com/space-wizards/space-station-14/blob/5476daf64ec8ac16b3e600d3cacfeb2fff3ee6d4/Content.Client/Clothing/ClientClothingSystem.cs#L306-L312

Layer data on jumpsuit doesn't fit cargo jumpsuit on line 312

Mirino97 commented 4 months ago

I have bumped the difficulty level and removed Beginner Friendly as I thought it was gonna be just a state path fix. Rewriting part or the entirety of a system is not all that Beginner Friendly