search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.63k stars 3.3k forks source link

The datafields on AutoTraitorComponent are broken #28093

Open Flareguy opened 5 months ago

Flareguy commented 5 months ago

Description

The datafields on AutoTraitorComponent are non-functional. This means you cannot remove their uplink or objectives.

Reproduction

  1. Spawn a humanoid prototype using SyndicateFootsoldierGear with the following component attached: 
    - type: AutoTraitor
  giveUplink: false
  giveObjectives: false
  2. Possess them
  3. Realize you still have traitor objectives
  4. Use your provided uplink code, realize that you still have an uplink

Screenshots image image

Additional context Possibly due to the traitor refactor. I cannot come to this conclusion to myself, since I do not know C#, but a member of the discord made this observation: image

metalgearsloth commented 5 months ago

Isn't this code deprecated?

Dutch-VanDerLinde commented 5 months ago

Isn't this code deprecated?

used on syndicate reinforcements

metalgearsloth commented 5 months ago

That doesn't mean it's not deprecated. Hardcoding a component just to add 1 antag seems like a code-smell when it should be able to setup any antag.

deltanedas commented 5 months ago

its specifically for controlling uplink and objectives