search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.62k stars 3.27k forks source link

Creatures without hands are able to unbuckle other creatures #28097

Open MjrLandWhale opened 4 months ago

MjrLandWhale commented 4 months ago

Description

Had a round on mander where I played as a mouse. I found a catatonic player hiding in the bathroom, and found that I was able to unbuckle them from the toilet even though I have no hands. As expected, I was unable to buckle them back into their seat, as I had no hands.

Reproduction

Attempt to unbuckle a buckled creature as a mouse. Screenshots

Additional context

lzk228 commented 4 months ago

seems easy to fix just add check for userUid handscomp https://github.com/space-wizards/space-station-14/blob/6082df7eac5d6ca443f4a0740227c4d281552f9a/Content.Shared/Buckle/SharedBuckleSystem.Buckle.cs#L385-L386 https://github.com/space-wizards/space-station-14/blob/6082df7eac5d6ca443f4a0740227c4d281552f9a/Content.Shared/Buckle/SharedBuckleSystem.Buckle.cs#L396-L422