search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.62k stars 3.27k forks source link

When shortening the shotgun #28450

Open Schrodinger71 opened 4 months ago

Schrodinger71 commented 4 months ago

Description

When shortening a shotgun with a circular saw or a hacksaw on metal, its cartridges disappear inside.

Reproduction Shorten a loaded shotgun

https://github.com/space-wizards/space-station-14/assets/132720404/aca9a921-a9c2-4d46-b56c-ed483816c05c

0x6273 commented 4 months ago

This is actually intended which is really stupid. https://github.com/space-wizards/space-station-14/pull/17971

EmoGarbage404 commented 4 months ago

i dont know if it'd call that "intended." The issue is that the sawn-off should carry over whatever ammo is currently in it. Before it had the same problem of just ignoring the ammo in the original shotgun, except it just spawned lethals instead. Now it just spawns nothing.

LankLTE commented 4 months ago

It’s not intended, it’s just preferable to getting free lethals. The best option would still be to carry over the shells.

ShadowCommander commented 4 months ago

Construction already transfers containers, but it seems like something is preventing that. ChangeEntity at https://github.com/space-wizards/space-station-14/blob/a9502be29e100edfa4d52aabf8dcaccb45f06c62/Content.Server/Construction/ConstructionSystem.Graph.cs#L289 should be breakpointed and stepped through to figure out why the shells aren't transferring when sawing off the barrel.

Kadeo64 commented 4 months ago

I thought the shotgun exploded when it was sawed-off with ammo still inside