search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.62k stars 3.29k forks source link

Mouse migration event always spawns a rat king #28480

Closed Tayrtahn closed 3 months ago

Tayrtahn commented 4 months ago

Description

The rat king spawn is listed as a special entry with a probability of 0.001 on the vent critters rule component. But the way the vent critters rule works is to always spawn one of the special entries (ignoring the probability) and then do another pass through the special entries for each spawn location (this time using the probability).

So there's always going to be at least one rat king added by the event, with a very small chance of another one for each vent.

Reproduction

Ghost and run addgamerule MouseMigration repeatedly. Watch the ghost roles list increase every time.

Screenshots

Additional context

Noticed while investigating #28455

deltanedas commented 4 months ago

rat king should just have its own rule (like on deltav) so it can have min pop etc independent of mouse spawns

LordJike commented 4 months ago

So create a new rule for spawning the rat king individually then have it referenced in Mouse migration rule only if the pop is higher than a threshold?

Scruq445 commented 4 months ago

but how many players should there be for the rat king event?

Scruq445 commented 4 months ago

We've agreed in the server that the player amount should be 15, making a PR now