space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.14k stars 2.84k forks source link

Meteors instantly explode on contact with liquids #29069

Open Dragonjspider opened 3 weeks ago

Dragonjspider commented 3 weeks ago

Description

I was testing the new meteor event as an admin on a local server with the latest build, and found out by accident after throwing an UristMcMeteor at an UristMcHands, they left blood and I threw another one at them, but it appears UristMcHands learned how to convert their blood into a shield and prevented a direct hit because of it

Reproduction Throw any kind of meteor at a liquid

Screenshots https://youtu.be/UWYnHeTz2pc

Additional context I dunno, not a coder 🤷

Tayrtahn commented 3 weeks ago

From a quick look at the code, it seems like running into anything that doesn't have a DestructibleComponent causes a meteor to take effectively infinite damage. That's probably a good thing in some cases, but a problem here.

WarMechanic commented 3 weeks ago

the 5u welding fuel puddle meteor shield :trollface: