search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.14k stars 2.84k forks source link

some entities ids is camelCase #29097

Open lzk228 opened 3 weeks ago

lzk228 commented 3 weeks ago

it should be PascalCase

MrMothman commented 3 weeks ago

Hello, I am a first time contributor of ss14 and I am going to take a crack at fixing this

MrMothman commented 3 weeks ago

This shouldn't affect behavior Id: correct? there are quite a few of those that are off, I also noticed that in EntityLists/ all of those also don't have pascal is that something we would like to fix as well? I am just making sure how global we want this change to be before I start do them all. I also noticed all dice dont have it and clinetsideclone.yml. and a lot of behavior id: on top of the specific storage sections ones. I just did this form the root of entities/ if you want the same list I'm looking at "find . -type f -name "*.yml" -exec grep -H -E 'id: [a-z]' {} +"

MrMothman commented 3 weeks ago

I made a judgement call PR is here: https://github.com/space-wizards/space-station-14/pull/29117