search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.12k stars 2.8k forks source link

Waddling needs reworking #29156

Open metalgearsloth opened 2 weeks ago

metalgearsloth commented 2 weeks ago

It's causing its own new set of bugs that need fixing and should've just used mob movement states / extended that functionality instead so we don't have to deal with the same bugs twice.

https://github.com/space-wizards/space-station-14/issues/26977 https://github.com/space-wizards/space-station-14/issues/26964 https://github.com/space-wizards/space-station-14/issues/26950

UbaserB commented 2 weeks ago

There are also issues on buckling now.

deltanedas commented 2 weeks ago

some of these should be addressed in the waddling rework #26983

UbaserB commented 2 weeks ago

some of these should be addressed in the waddling rework #26983

Im saying ive experienced all these bugs when i played clown, TODAY

SlamBamActionman commented 2 weeks ago

Unless it's the actual opinion, change the title to "Waddling needs reworking".

Removing makes it sound like it's an undesired feature, when it's the code that is bad.

metalgearsloth commented 2 weeks ago

Removing makes it sound like it's an undesired feature, when it's the code that is bad.

Sure.

With that being said I would rather remove the code from master until reworked rather than inadvertantly have more bugfixes PRd for the sake of optimising maintainer time and reviews.

SlamBamActionman commented 2 weeks ago

That's fair, that's what we did with executions after all.

FairlySadPanda commented 2 weeks ago

As noted on the Replicates Etc PR, this can only be "properly" implemented on top of a proper animation state machine system, which is a multi-month project. Just bolting this code onto a different set of inputs is insufficient to stop things breaking further in the future.

Fundamentally this should be a feature that changes a mobs' walking animation from a smooth walk to a waddling one, not having to bolt on an additive layer in code.

Oh and animations need migrating to YAML. So uh it's a far larger project than what I originally took on. Something something Harold Have You Fixed That Light In The Kitchen

IProduceWidgets commented 1 week ago

Just going to tack on that ai mobs can't waddle with the current system, which makes me very sad because it's clearly intended to be used on ducks.