space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.12k stars 2.8k forks source link

Remove .vscode from version control #29285

Closed diraven closed 6 hours ago

diraven commented 1 week ago

Description

.vscode settings being in VCS forces everybody to use them and prevents customization. Workspace settings override user settings. Which means you effectively can't customize workspace settings for this project at all without your changes ending up in VCS, which is very likely an undesirable outcome.

I believe the right thing to do here would be:

That way we can still distribute configuration changes/templates if need be with devs retaining the ability to change their local workspace settings including settings.json, tasks.json and launch.json.

diraven commented 1 week ago

I'll make a PR for it later if there are no hard objections to this.

PJB3005 commented 1 week ago

Doesn't VSCode have a "default workspace settings" system exactly for this purpose?

osjarw commented 1 week ago

Not an expert on these particular settings, but stuff like formatter settings definitely should belong in the workspace settings.

diraven commented 1 week ago

Doesn't VSCode have a "default workspace settings" system exactly for this purpose?

Didn't find such functionality in VSCode. Only thing I found is this ancient issue, which was not worked on yet it seems. You got a link?

Not an expert on these particular settings, but stuff like formatter settings definitely should belong in the workspace settings.

It probably should. But that's a bit out of scope for this issue.