search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.62k stars 3.27k forks source link

Mouse controlled box with chef's hat #29287

Open Cojoke-dot opened 3 months ago

Cojoke-dot commented 3 months ago

Description

Some waky things happen if a mob who is piloted by a mouse with a chef hat tries to move at the same time as the mouse when in a box. Reproduction

  1. mouse in chef hat
  2. put hat on player
  3. put player in cardboard box
  4. move

Additional context

From looking at the videos in the pr that added the chef's hat fun and how it feels when you're in the box, my guess is that being in the box re-enables prediction for the two controlling the box. https://github.com/space-wizards/space-station-14/pull/25950#issuecomment-1988471652

Tayrtahn commented 3 months ago

Tricky! Being controlled by a mouse disables prediction for the player's character, but if the player is controlling another entity (like a box), that entity doesn't have its prediction disabled. This will probably cause the same issue with vehicles, once they've been reimplemented.

Probably could do something where the prediction disabling is propagated up through containers, or maybe the prediction check event should be related to children.