search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.14k stars 2.84k forks source link

Player strip menu title doesnt update on identity change #29446

Open lzk228 opened 2 weeks ago

Aexxie commented 2 weeks ago

This one needs more context. Do you mean it doesn't update when you change your identity with an Agent ID?

I also noticed a more prominent issue while looking into this one, probably related. Admin Command rename doesn't work on humanoids and the likes; when viewing as a ghost or admin, it shows the humanoid as if they had their face covered and have someone else's ID.

Non-Admin/Player view: image image

Admin/Ghost view: image image

This also affects the "rename" trick.

lzk228 commented 2 weeks ago

i mean strip menu, for example when you open Urist's strip menu, you see Urist McHands in title, but if they change identity (wear mask and Pun Pun id) the title is still Urist McHands

lzk228 commented 2 weeks ago

here i provided a video

https://github.com/space-wizards/space-station-14/assets/124214523/d6f86f35-be79-4b5a-a5d4-eec065d614f7

Tayrtahn commented 2 weeks ago

Yeah, I noticed this with the name modifier stuff. The window title doesn't update when the target's name changes.

Recent engine work added an event that gets raised when an entity's name is changed. It might be as easy as subscribing to that on the client and updating the window, but I'm not familiar enough with UI stuff to be sure.