space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.13k stars 2.81k forks source link

Ninja suit not properly using batteries #29477

Open baddiePRO opened 1 week ago

baddiePRO commented 1 week ago

Description

while playing as ninja, if you swap a low battery with a fresh battery, it does not show the correct percentage on the suit and you still have to charge with the ninja gloves.

Reproduction

be ninja swap low battery for full battery suit power does not increase, despite having a fully charged battery

EDIT** new info, apparently ninja suit doesn't consume batteries at all

TurboTrackerss14 commented 1 week ago

Battery swapping was removed to enforce people to use the actual charging interaction of the gloves.

Is it actually taking the new battery? Can you provide a video of it swapping a small to a medium etc. Because that shouldn't be possible.

My assumption is its just a ui mispredict showing the full battery that isn't actually inserted.

thebadman4662 commented 1 week ago

Battery swapping works, at very least you can upgrade them from the default small.

deltanedas commented 1 week ago

battery swapping was never allowed, need actual repro steps

TurboTrackerss14 commented 1 week ago

https://github.com/space-wizards/space-station-14/pull/15491

https://github.com/space-wizards/space-station-14/issues/28170

it never ends.

baddiePRO commented 1 week ago

Battery swapping was removed to enforce people to use the actual charging interaction of the gloves.

TIL lol

Is it actually taking the new battery? Can you provide a video of it swapping a small to a medium etc. Because that shouldn't be possible.

I will do that as soon as I get a chance :)

Radezolid commented 1 week ago

From my experience, you can change the battery ONCE, for example from the small to the medium one, after that you're fucked. It starts bugging out, you cant recharge sometimes, sometimes it tells you full battery but it doesnt let you use abilities.

I'll try to recreate it and post a video of it

Radezolid commented 1 week ago

If you try to swap for a downgrade or same tier of cell the issue happens, it gets fixed once you upgrade the cell.

https://github.com/space-wizards/space-station-14/assets/170836000/6937b9a8-59ea-4a1b-9ffc-13255eed13b8

deltanedas commented 1 week ago

either mispredict or battery swap somehow isnt updating the battery drainer uid will need to vv to be sure