space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.15k stars 2.86k forks source link

ALL borgs can burn themself on lights #29502

Open bruhmogus opened 2 weeks ago

bruhmogus commented 2 weeks ago

Description

Every borg can burn themself on a light bulb. They must have their module unequipped (none/manually unequipped)

Reproduction Step 1. Control ANY borg chassis (syndie, role, science created) Step 2. Manually unequip your module if you have one Step 3. Click on a light Step 4. Die

Screenshots 20240626191724_1

Additional context It does deal damage to the borg and it does say that you burn your HAND

Plykiya commented 2 weeks ago

perhaps this shouldn't even be a feature this is like the only thing in the game you can spam click within 2 seconds to kill yourself, people just abuse it to cauterize themselves, and for some reason only black gloves and some of the higher tier gloves let you unscrew them safely

not really realistic at all

Plykiya commented 2 weeks ago

image hmmmm removed in what way I wonder

bruhmogus commented 2 weeks ago

i just realised im a bit vague on this, this is a BUG REPORT

Plykiya commented 2 weeks ago

i just realised im a bit vague on this, this is a BUG REPORT

I'm aware, the fix for this just requires thinking about what actually needs to be done without ignoring the TODO comments. We don't want to add a component that just makes some entities immune from getting burned on lightbulbs, especially since the TODO comment implies the glove component shouldn't even exist

But there's also the fact that borgs somehow have hands with no modules...

bruhmogus commented 2 weeks ago

i just realised im a bit vague on this, this is a BUG REPORT

I'm aware, the fix for this just requires thinking about what actually needs to be done without ignoring the TODO comments. We don't want to add a component that just makes some entities immune from getting burned on lightbulbs, especially since the TODO comment implies the glove component shouldn't even exist

But there's also the fact that borgs somehow have hands with no modules...

this might be fixable by just checking light bulbs for which component makes it burn you, maybe just add a check that also asks if the entity has a hand

IProduceWidgets commented 2 weeks ago

Ill be honest, I just always thought it was whether your gloves were insulated or not. I would just use that if you dont plan to rip it out completely.