Dropping an item while in a container places the item outside of the container

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.

https://spacestation14.io

MIT License

2.13k stars 2.81k forks source link

Dropping an item while in a container places the item outside of the container #29624

Open Plykiya opened 5 days ago

Plykiya commented 5 days ago

Description

TI TLE

Kind of an odd bug because all of the code implies that it handles the situation and accounts for it. Let's see why that doesn't happen...

Reproduction

Screenshots

Additional context

Plykiya commented 5 days ago

both DropNextTo and PlaceNextTo say they account for if the parent is in a container... but both methods fail to work either when you drop the item or strip the items off of someone....

Plykiya commented 5 days ago

ah, I sort of understand now. It's just a broken interaction with the extra DoDrop rather than the DropNextTo/PlaceNextTo functions.

Plykiya commented 5 days ago

Infinite sleep deprivation Duplicate issue of: https://github.com/space-wizards/space-station-14/issues/17230 Solved in: https://github.com/space-wizards/space-station-14/pull/28167 (I even commented on it)

But the PR seems dead so I'll work on it. The one issue it did not solve is that when your hands are full and you're speed stripping someone in a locker or disposal container, it drops outside. I'm going to address that problem by nerfing speed stripping......