space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.62k stars 3.27k forks source link

ItemPlacer should be using placeable code #29676

Open metalgearsloth opened 3 months ago

metalgearsloth commented 3 months ago

Using collision events is a hack when we have code specifically for this usecase.

Adding extra fixtures is just going to slow the game down and https://github.com/space-wizards/space-station-14/pull/28117 is a bandaid around the actual problem.

AJCM-git commented 3 months ago

I think a way worth exploring to handle "Placing" pulled stuff like artifacts onto the analyzer could be making use of the virtual item that appear when you pull stuff instead of listening to collision events (so pull artifact > click analyzer with the virtual item > artifact is placed on the analyzer)