space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.7k stars 3.39k forks source link

Contraband category mega-issue #31047

Open slarticodefast opened 2 months ago

slarticodefast commented 2 months ago

Let's collect all of them here so we have a better overview. If you find an item that got the wrong contraband category write a comment and I will add it to the list.

Everturning commented 2 months ago

Please make it so secglasses are SECURITY restricted, not command/security. Also we need some sort of difference between "highly illegal syndicate contraband" and stuff like the syndie flag, like "This is somewhat illegal syndicate contraband, but you should be fine to carry it around" and "This is central command restricted contraband!"

slarticodefast commented 2 months ago

Please make it so secglasses are SECURITY restricted, not command/security.

This is currently being discussed with the admins. A possible solution could be the addition of the special command glasses, which only show the job icon, but not wanted status #30447

JIPDawg commented 2 months ago

Please make it so secglasses are SECURITY restricted, not command/security.

This is currently being discussed with the admins. A possible solution could be the addition of the special command glasses, which only show the job icon, but not wanted status #30447

Would still need to make SecGlasses restricted right? What would be stopping Command from just ditching the command glasses and getting SecGlasses.

slarticodefast commented 2 months ago

Would still need to make SecGlasses restricted right? What would be stopping Command from just ditching the command glasses and getting SecGlasses.

Yes, that would have to be added to that PR.

Dutch-VanDerLinde commented 2 months ago

the fire axe has its own design and description so it isnt a stealth item

TheDoctor1977 commented 2 months ago

The raid suit's helmet (not the actual suit) says it's departmentally restricted instead of syndicate contraband

Savsj commented 2 months ago

Merc gear should be sec restricted i belive its currently incorrectly parented as syndie gear

UBlueberry commented 2 months ago

The CE's advanced magboots are listed as engineering restricted, not command restricted Also they don't have the "This item is a highly valuable target for Syndicate agents!" tag

supersayangoblin commented 2 months ago

the acolyte armor should be listed as syndicate or minor contraband, because it is functional armor exclusive to emagging a vendor. there is no other way to get it other than emagging the pietyvendor

Golinth commented 2 months ago

Nukie Plushie?

The Nukie Plushie can spawn in the cap's locker, it would be weird to include it as contraband imo

slarticodefast commented 2 months ago

The Nukie Plushie can spawn in the cap's locker, it would be weird to include it as contraband imo

It currently is contraband. That's why I added it. I'll make it more clear

TurboTrackerss14 commented 2 months ago

https://github.com/space-wizards/space-station-14/blob/6a549ceee4a411197a39077649be4cb1326d8caf/Resources/Prototypes/Entities/Objects/Weapons/Melee/knife.yml#L139

Bladed flatcap is an improvised weapon but is marked as syndicate contraband

supersayangoblin commented 2 months ago

https://github.com/space-wizards/space-station-14/blob/6a549ceee4a411197a39077649be4cb1326d8caf/Resources/Prototypes/Entities/Objects/Weapons/Melee/knife.yml#L139

Bladed flatcap is an improvised weapon but is marked as syndicate contraband

it really SHOULDN'T be marked as contraband, as its a stealthy weapon (last time i checked)

slarticodefast commented 2 months ago

it really SHOULDN'T be marked as contraband, as its a stealthy weapon (last time i checked)

Good point. You can still see the damage it does upon examination though, so it's still kinda obvious?

supersayangoblin commented 2 months ago

Good point. You can still see the damage it does upon examination though, so it's still kinda obvious?

you can see a hypopen's reagent counter on inspection, but that doesn't make it immediately obvious contraband. If the weapon has a line stating it's bladed in its description box, however, then its fair game (this is the part I'm not so sure of, because i forget the description)

TurboTrackerss14 commented 2 months ago

image image

Probably should be restricted to cargo considering the armor? (considering its literally better than sec gasmask armor)

slarticodefast commented 2 months ago

Probably should be restricted to cargo considering the armor? (considering its literally better than sec gasmask armor)

Do they have that round-start or is it salvage loot?

EmoGarbage404 commented 2 months ago

explorer masks are just roundstart stuff.

Golinth commented 2 months ago

Probably should be restricted to cargo considering the armor? (considering its literally better than sec gasmask armor)

Do they have that round-start or is it salvage loot?

Round start salv. I don’t remember if you can get more, I don’t think so though. Maybe when finding a mining suit crate.

TurboTrackerss14 commented 2 months ago

image ERT mask = contraband :trollface:

UbaserB commented 2 months ago

Bandolier is not allowed by the bartender

image

lzk228 commented 2 months ago

cleanades marked as contraband

Djungelskog2 commented 2 months ago

image thinking about it... what if people get promoted?

image It shouldnt because its a stealth item

image Shouldnt it be department restricted? (Security, comes in bagel armoury)

image I dont... why??? you can get it from the lottery and its not syndicate related in any way outside of it being accessible from the uplink, and its got no functional usage

slarticodefast commented 2 months ago

thinking about it... what if people get promoted?

I think it is tied to your ID's access, so if that changes with your promotion you should be fine.

It shouldnt because its a stealth item

It got the word "thief" right in its name, so no stealth at all. If you want it to be stealthy, it should be named toolbox instead.

Shouldnt it be department restricted? (Security, comes in bagel armoury)

Corrected it.

cat ears

Because funny, also they were considered contraband before

Djungelskog2 commented 2 months ago

I thought the thief toolbox was just a normal toolbox namewise till interacted with, mb

But I don't recall the cat ears ever being contraband? (Before the OG pr for this came out and before contraband rules in spacelaw were nuked)

slarticodefast commented 2 months ago

Found these: grafik grafik grafik grafik

So I guess the admin answer is 🤷‍♂️

Djungelskog2 commented 2 months ago

I have also been told that it's contraband if it's "primarily obtained in the uplink" and I think cat ears are common enough from lotteries to be excluded from that

CookieMasterT commented 2 months ago

The swat gasmask that Head of security starts with is marked as cargo restricted

TurboTrackerss14 commented 2 months ago

image

Dragonjspider commented 2 months ago

Salvage use normal magboots for their job and can get them out of their locker, but they're restricted to engineering so they appear to be contraband to salvagers

themias commented 1 month ago

Some armors might need to be marked as contraband:

deltanedas commented 1 month ago

Salvage use normal magboots for their job and can get them out of their locker, but they're restricted to engineering so they appear to be contraband to salvagers

the eva room also has magboots i think, so it should just be removed or changed to say jobs with external access

slarticodefast commented 1 month ago

I thought normal magboots being contra was fixed already? grafik

Dragonjspider commented 1 month ago

I thought normal magboots being contra was fixed already? grafik

It was yes... three days after I mentioned it... #30960 :trollface:

Golinth commented 1 month ago

galoshes should be jani restricted. Ive seen officers justify using them because they "arent really contra"

Golinth commented 1 month ago

x-ray cannons are not security restricted image

Golinth commented 1 month ago

The HoS’s trench coat is not security restricted

Golinth commented 1 month ago

Omega soap should probably be contraband, it's syndie soap but better, and iirc was considered contraband before the inspect came along

averystarbits commented 1 month ago

Please make it so secglasses are SECURITY restricted, not command/security.

This is currently being discussed with the admins. A possible solution could be the addition of the special command glasses, which only show the job icon, but not wanted status #30447

Administrative glasses would be AWESOME, the admin hud isn't flash immune.

ArtisticRoomba commented 1 month ago

Administrative glasses would be AWESOME, the admin hud isn't flash immune.

we already have admin glasses and admin huds

K-Dynamic commented 1 month ago

Dogi needs to be marked as Syndicate contraband, obtainable from emagged TheatreDrobe and has decent armor protection.

slarticodefast commented 1 month ago

@golinth I asked admins about the omega soap. I think it is fine without being contraband. grafik