Singularity generators are inexplicably one pixel off on the top half

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.

https://spacestation14.io

MIT License

2.71k stars 3.42k forks source link

Singularity generators are inexplicably one pixel off on the top half #31295

Open bruhmogus opened 2 months ago

bruhmogus commented 2 months ago

Description

Title.

Screenshots 20240821191317_1

Additional context my eyes

Golinth commented 2 months ago

Dear god WHY

Magicalus commented 2 months ago

So, fun (read: horrifying) news, the entire sprite is actually to the right one pixel. It's got a 1 pixel centerline, so it's gotta be shifted a pixel right or left of center. Fixing this means reworking the sprite to have a two pixel center :[

Here's the sprite on a grid to show the issue more clearly: Screenshot_20240825_191435

Moomoobeef commented 2 months ago

aaaaaaaaaaaaaaaaaaaauuuhgghhhhh

well I do need some aseprite practice so I guess I can do it besides, I've actually always hated this sprite, the anti-aliased rings look fugly, I've noticed before it was off center, and the edges on the sides and top look way too sharp

Moomoobeef commented 2 months ago

what do people think about this one

Magicalus commented 2 months ago

what do people think about this one

I like it! Moving the ring up off the base makes it feel a lot less... flat, I guess? I dunno, just a nice change imo. Plus, no more weird half transparent pixels.

Moomoobeef commented 2 months ago

yea I tried to make it not feel so flat, because looking at the old one felt like looking at something 2d in a 2.5d world

waiting to hear some more feedback from folks either here or in #sprite-dungeon but once I have another OK I'll probably make the PR