Infinite range on crowbar tile prying

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.

https://spacestation14.io

MIT License

2.74k stars 3.48k forks source link

Infinite range on crowbar tile prying #31819

Open Graded5 opened 2 months ago

Graded5 commented 2 months ago

Description

Do after doesnt cancel if you move out of range.

Reproduction -Have no gravity -Be gliding quickly -Begin prying a tile behind you thats in range. -Observe as your arms get insanely long as you drift out of range

godisdeadLOL commented 2 months ago

https://github.com/space-wizards/space-station-14/blob/582a644c243d1c0a0ff660933e811b89024597f6/Content.Shared/Tools/Systems/SharedToolSystem.Tile.cs#L91

tool and target are the same value. Probably because action target is a tile. I tried passing coordinates.EntityId but it's not working.

deltanedas commented 2 months ago

it should break on user move since there is no target entity

godisdeadLOL commented 2 months ago

I think BreakOnWeightlessMove = false allows you to just float in zero gravity without stopping prying.