search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.7k stars 3.38k forks source link

Your implementation of LINDA has a broken comparison check #32053

Closed LemonInTheDark closed 1 month ago

LemonInTheDark commented 1 month ago

Description

compare() (in /tg/ code) and CompareExchange() (in ss14) as they apply to linda have been broken for a while. Because they do not account for archived moles they introduce order of operations issues to gas sharing, meaning some turfs that SHOULD be made active and gain gas just... don't. This makes gas flow technically directional.

See the second issue described in https://github.com/tgstation/tgstation/pull/86602

Additional context From a brief check this may be mildly annoying since you seem to have moved archive moles (and temperature) off the gasmixture in the name of cleanly supporting multiple systems.

mirrorcult commented 1 month ago

wonky

LemonInTheDark commented 1 month ago

swinging by for my biyearly "something is wrong with linda" post, hope you're all well

metalgearsloth commented 1 month ago

Time to tell all 0 of our active atmos coders.