search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.71k stars 3.43k forks source link

Masks with flash, eye, and damage protection still work when pulled down #32714

Open K-Dynamic opened 1 month ago

K-Dynamic commented 1 month ago

Description

Discovered with #32691. Masks with flash, eye, and damage protection still protect even when toggled to pull down.

This has potential to mislead players who think their opponent is missing protection.

Reproduction Flash and eye protection

  1. Wear mask with flash and eye protection (Syndicate or Welding Gas Masks)
  2. Toggle mask to pull down
  3. Flash or weld
  4. Be unaffected by either flash or weld

Damage protection

  1. Wear mask with damage protection
  2. Toggle mask to pull down
  3. Attack yourself
  4. Check health
  5. Repeat and compare health with not wearing a mask at all

For example, wear a deathsquad helmet, pull down your mask, and attack yourself with wielded sledgehammer. The attack should 20 blunt damage but only does 16, despite the mask being pulled down.

Cojoke-dot commented 1 month ago

By pulled down you mean not on your face?

thebadman4662 commented 1 month ago

By pulled down you mean not on your face?

In head slot(which is what gives immunity ex: resistances and mask flash immunity) but in not active state(like hardsuit or gas mask for internals) I reckon.

K-Dynamic commented 1 month ago

In head slot(which is what gives immunity ex: resistances and mask flash immunity) but in not active state(like hardsuit or gas mask for internals) I reckon.

Neck/mask slot but yes

thebadman4662 commented 1 month ago

Oh, I was puzzled why you are making issue for your own PR that is not even merged... You just discovered syndie masks do not need to be on face for protection eh? That bug/feature™ is one(only?) reason that weldmask from sci isn't a toggle but rather equippable only.

K-Dynamic commented 1 month ago

Oh, I was puzzled why you are making issue for your own PR that is not even merged... You just discovered syndie masks do not need to be on face for protection eh? That bug/feature™ is one(only?) reason that weldmask from sci isn't a toggle but rather equippable only.

It's an issue to report for recordkeeping and both gas masks have this bug. It was also never documented if welding gas mask was untoggleable because of it.

K-Dynamic commented 4 weeks ago

Alright I've appended another issue to this - masks with damage protection still work even when pulled down