space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.63k stars 3.3k forks source link

Masks with flash and eye protection work even when pulled down #32714

Open K-Dynamic opened 3 days ago

K-Dynamic commented 3 days ago

Description

Discovered with #32691. Masks with flash and eye protection still protect from flashes or welding when toggled to pull down.

This has potential to mislead players who think their opponent is missing protection.

May need to check if masks offer armour protection even when pulled down.

Reproduction

  1. Wear mask with flash and eye protection (Syndicate or Welding Gas Masks)
  2. Toggle mask to pull down
  3. Flash or weld
  4. Be unaffected by either flash or weld
Cojoke-dot commented 3 days ago

By pulled down you mean not on your face?

thebadman4662 commented 3 days ago

By pulled down you mean not on your face?

In head slot(which is what gives immunity ex: resistances and mask flash immunity) but in not active state(like hardsuit or gas mask for internals) I reckon.

K-Dynamic commented 3 days ago

In head slot(which is what gives immunity ex: resistances and mask flash immunity) but in not active state(like hardsuit or gas mask for internals) I reckon.

Neck/mask slot but yes

thebadman4662 commented 3 days ago

Oh, I was puzzled why you are making issue for your own PR that is not even merged... You just discovered syndie masks do not need to be on face for protection eh? That bug/feature™ is one(only?) reason that weldmask from sci isn't a toggle but rather equippable only.

K-Dynamic commented 3 days ago

Oh, I was puzzled why you are making issue for your own PR that is not even merged... You just discovered syndie masks do not need to be on face for protection eh? That bug/feature™ is one(only?) reason that weldmask from sci isn't a toggle but rather equippable only.

It's an issue to report for recordkeeping and both gas masks have this bug. It was also never documented if welding gas mask was untoggleable because of it.