space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.7k stars 3.38k forks source link

No nuke at thief #32895

Open Futuristic-OK opened 2 weeks ago

Futuristic-OK commented 2 weeks ago

Description

Thief can`t get goals for Nuke and Ian, because someone make shit-code after realese from Shhhed

Screenshots image Nuke have difficulty 2,5 and can`t be received. Same with Ian

Additional context At release this work good, but now it broken, i think. If i silly and read code wrong, say me, what mean 2 difficulty at screenshot

slarticodefast commented 2 weeks ago

Please don't call someone else's code shit. If there is a bug it is ok to point that out. What exactly is broken? The assignments for these two objectives? How did you test this?

TurboTrackerss14 commented 2 weeks ago

https://github.com/space-wizards/space-station-14/blob/77a2907535d10168a119087f1f8c46a080a679be/Resources/Prototypes/GameRules/midround.yml#L16 This would certainly be an interesting bug considering thieves have a 2.5 max difficulty rating.

Can you do a test to confirm this? aka comment out the other thief objectives and confirm neither of these two objectives role at all?

https://github.com/space-wizards/space-station-14/blob/77a2907535d10168a119087f1f8c46a080a679be/Content.Server/Antag/AntagRandomObjectivesSystem.cs#L42 Would indicate that it is certainly ABLE to be rolled, just simply that they are all but required to be rolled first as they take up a very large chunk of the thiefs available difficulty.