space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.73k stars 3.47k forks source link

AI is only affected by law changes if an AI is in the AI core #33080

Open PotentiallyTom opened 3 weeks ago

PotentiallyTom commented 3 weeks ago

Description

AI is only affected by law changes if they're in the core when the law change happens. Ideally it would "buffer" the change while an AI is not in the core, and apply it when one arrives.

Reproduction

Case 1:

  1. Play a round without a roundstart AI
  2. Insert a law board
  3. AI joins
  4. They're on crewsimov

Case 2:

  1. Intellicard the AI
  2. Insert a law board
  3. Put the AI back in the core
  4. Laws haven't changed

Screenshots

Additional context

ScarKy0 commented 3 weeks ago

This is true and sadly the case due to how the LawUpdater works Hopefully someone who tackles freeform could fix this too