search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.72k stars 3.46k forks source link

Project Zero Warnings #33279

Open PJB3005 opened 1 week ago

PJB3005 commented 1 week ago

Description

The game produces a ton of compiler warnings when built right now:

image

This has gradually piled up over years of development to RT and SS14, primarily due to deprecation of old APIs.

Incrementally cleaning up the code to remove these warnings is something any contributor can do in small batches. Contributions appreciated!

For MOTIVATIONAL REASONS, if want to track our progress, we have a public Grafana dashboard that tracks the repo's total warning count over time!

thetolbean commented 1 week ago

Can we assume then that maintainers are going to be more focused on preventing PR's from introducing more warnings?

PJB3005 commented 1 week ago

Can we assume then that maintainers are going to be more focused on preventing PR's from introducing more warnings?

My current stance is that PRs adding warnings isn't big enough of a deal to warrant the effort to implement an automatic CI enforcement system like that. Best to just fix all the warnings right now.